-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[PM-20225] Block no-userkey legacy users #5640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5640 +/- ##
==========================================
- Coverage 45.80% 45.79% -0.01%
==========================================
Files 1609 1609
Lines 73170 73189 +19
Branches 6556 6560 +4
==========================================
+ Hits 33516 33518 +2
- Misses 38226 38242 +16
- Partials 1428 1429 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you for making the error result more explicit.
🎟️ Tracking
https://bitwarden.slack.com/archives/C07HC7E5BPW/p1744304953289719
https://bitwarden.atlassian.net/browse/PM-20225
📔 Objective
Blocks legacy users without a userkey from logging in entirely on clients that are above or equal to 2025.5.0.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes